Android: Clean up lint warnings and other warnings to get build success #12143

Sangamesh1997 · 2025-06-10T09:40:42Z

Fixes : #6868 #12142
Worked on clearing the lint warnings (OldTargetApi, ObsoleteSdkInt, InlinedApi, NewApi)

Sangamesh1997 · 2025-06-19T05:49:54Z

@ejona86 @shivaspeaks Can you please review.

kannanjgithub · 2025-06-19T06:51:42Z

@Sangamesh1997 Can you provide the build error log that you are fixing with this PR? In the failing build.log of PR #12040 I don't see any errors about @TargetApi for example.

Sangamesh1997 · 2025-06-19T08:23:17Z

@kannanjgithub In the build log of PR #12040 , I observed that the only visible lint error was OldTargetApi. However, when I ran the lint check locally in (lint report.html), it also flagged other warnings like InlineApi, ObseleteSdkInt and NewApi, as mentioned by Eric earlier. So in this PR, I've fixed all these together to ensure build passes cleanly and is future-proof.

kannanjgithub · 2025-06-19T09:39:02Z

@Sangamesh1997 can you share that lint report.html?

Sangamesh1997 · 2025-06-19T09:52:40Z

@kannanjgithub lint report details.txt

shivaspeaks

Are we working on silencing? I thought the discussion happened to upgrade and fix in the #12040 (comment)

Sangamesh1997 · 2025-06-20T06:35:03Z

Are we working on silencing? I thought the discussion happened to upgrade and fix in the #12040 (comment)

@shivaspeaks I have addressed and cleared all the lint warnings in #12143, which resolves the issue tracked in #6868.
Since the team is currently working on upgrading the Android Gradle Plugin (AGP) in #10152, the target SDK upgrade to 35/36 will be taken up after that is complete.
That’s why I focused on cleaning up the lint warnings first — to help unblock and resolve the 6868 issue as a separate step.

kannanjgithub · 2025-07-10T10:50:52Z

Since the team is currently working on upgrading the Android Gradle Plugin (AGP) in #10152, the target SDK upgrade to 35/36 will be taken up after that is complete.

Does it cause any problem if you set targetSdkVersion to the latest available even while the AGP is not upgraded yet? @Sangamesh1997

kannanjgithub · 2025-07-10T11:38:26Z

binder/src/main/java/io/grpc/binder/AndroidComponentAddress.java

@@ -165,6 +166,7 @@ public Intent asBindIntent() {
   *
   * <p>See {@link Intent#URI_ANDROID_APP_SCHEME} for details.
   */
+  @SuppressLint("InlinedApi")


The warning inlinedApi is about using the constant URI_ANDROID_APP_SCHEME that was introduced in API level 22. Instead do intentForUri.toUri(android.os.Build.VERSION.SDK_INT < 22? URL_INTENT_SCHEME : URI_ANDROID_APP_SCHEME);

and remove the suppression. If the linter still complains, then add @TargetApi(22) to indicate that we are only using URI_ANDROID_APP_SCHEME at and above API level 22.

@kannanjgithub yes fixed with conditional version check only - lint warnings resolved without @TargetApi working.

kannanjgithub · 2025-07-10T11:51:40Z

binder/src/main/java/io/grpc/binder/internal/ServiceBinding.java

@@ -183,18 +184,22 @@ private static Status bindInternal(
          bindResult = context.bindService(bindIntent, conn, flags);
          break;
        case BIND_SERVICE_AS_USER:
-          bindResult = context.bindServiceAsUser(bindIntent, conn, flags, targetUserHandle);
+          if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) {


It is going to fail the connection with Unimplemented for Android API levels 21 - 29. It would already be crashing for these API levels? @ejona86 . Also for similar changes below.

@jdcormie probably knows what's going on better. But I'd expect we need proper error handling here, and not claiming things are UNIMPLEMENTED. INTERNAL with a message that the API is not available might be fair.

Regarding bindServiceAsUser(), I agree that we should not fail with UNIMPLEMENTED in this case because that already means something else that applications do want to handle very specifically.

If we reach this line it's because targetUserHandle != null which means the application is asking for a cross-user Channel. The public entry point to this feature already documents an SDK >= 30 requirement which is why the old behavior of crashing with an NoSuchMethodError was actually totally fine IMHO. IF we just do checkState(SDK_INT >= 30, "Cross user Channel requires Android R+") would that make the linter happy and yield the desired INTERNAL error?

kannanjgithub · 2025-07-10T11:52:57Z

lint.xml

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<lint>
+    <issue id="OldTargetApi" severity="ignore" />


Does it cause any problem if you set targetSdkVersion to the latest available even while the AGP is not upgraded yet?

Yes, it causes AAPT2 linking failures due to resource format changes. AGP 7.x is incompatible with SDK 35/36, so AGP must be upgraded first. keeping the lint.xml suppression after upgrading AGP/SDK won’t break anything, and have to remove it after the AGP/SDK upgrade to keep our configuration clean.

Include that relevant information here as a comment, so it is clear when it can be removed.

…xed_12142 # Conflicts: # binder/src/main/java/io/grpc/binder/internal/ServiceBinding.java

Sangamesh1997 · 2025-07-11T04:46:50Z

Since the team is currently working on upgrading the Android Gradle Plugin (AGP) in #10152, the target SDK upgrade to 35/36 will be taken up after that is complete.

Does it cause any problem if you set targetSdkVersion to the latest available even while the AGP is not upgraded yet? @Sangamesh1997

@kannanjgithub I tried and got a build failure with 'AAPT2 error: Android resourse linking failed'. SDK 35/36 introduced internal changes in resource formats. The current AGP versions cant handle these changes during resource linking. that's why I suspect that using compileSdk>34 is unsafe unless AGP is upgraded to 8.x.+.

ejona86 · 2025-07-28T21:22:54Z

lint.xml

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<lint>
+    <issue id="OldTargetApi" severity="ignore" />


Include that relevant information here as a comment, so it is clear when it can be removed.

ejona86 · 2025-07-28T21:24:45Z

binder/src/main/java/io/grpc/binder/internal/ServiceBinding.java

@@ -183,18 +184,22 @@ private static Status bindInternal(
          bindResult = context.bindService(bindIntent, conn, flags);
          break;
        case BIND_SERVICE_AS_USER:
-          bindResult = context.bindServiceAsUser(bindIntent, conn, flags, targetUserHandle);
+          if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) {


@jdcormie probably knows what's going on better. But I'd expect we need proper error handling here, and not claiming things are UNIMPLEMENTED. INTERNAL with a message that the API is not available might be fair.

ejona86 · 2025-07-28T21:28:12Z

binder/src/main/java/io/grpc/binder/AndroidComponentAddress.java

@@ -172,7 +175,10 @@ public String asAndroidAppUri() {
      // factory methods. Oddly, a ComponentName is not enough.
      intentForUri = intentForUri.cloneFilter().setPackage(getComponent().getPackageName());
    }
-    return intentForUri.toUri(URI_ANDROID_APP_SCHEME);
+    return intentForUri.toUri(
+              Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP_MR1


Can you bump the minimum SDK version to 22 instead of this change? We should already be on 23, and in a few days, maybe could even do 24. Bumping to 23 might introduce more warnings, but 21->22 seems likely to be trivial.

Falling back to an intent: URI isn't OK. The method name and javadoc explicitly say we'll return an android-app:// URI.

min SDK bump SGTM.

Sangamesh1997 added 4 commits June 10, 2025 09:36

Android: worked on lint and build warnings

3f241f8

Merge branch 'grpc:master' into Issue_fixed_12142

77bed78

Merge branch 'grpc:master' into Issue_fixed_12142

c414609

Merge branch 'grpc:master' into Issue_fixed_12142

03b453b

shivaspeaks added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jun 19, 2025

grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jun 19, 2025

shivaspeaks reviewed Jun 19, 2025

View reviewed changes

shivaspeaks requested a review from ejona86 June 19, 2025 16:02

Merge branch 'grpc:master' into Issue_fixed_12142

53a4385

Sangamesh1997 mentioned this pull request Jun 26, 2025

Clean up lint warnings to unblock #6868 #12142

Closed

Merge branch 'grpc:master' into Issue_fixed_12142

e5272b3

shivaspeaks added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 2, 2025

grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 2, 2025

Merge branch 'grpc:master' into Issue_fixed_12142

37f84d1

shivaspeaks self-requested a review July 8, 2025 08:32

kannanjgithub reviewed Jul 10, 2025

View reviewed changes

Sangamesh1997 closed this Jul 11, 2025

Sangamesh1997 force-pushed the Issue_fixed_12142 branch from 37f84d1 to 94532a6 Compare July 11, 2025 02:50

Merge remote-tracking branch 'origin/Issue_fixed_12142' into Issue_fi…

65fab31

…xed_12142 # Conflicts: # binder/src/main/java/io/grpc/binder/internal/ServiceBinding.java

Sangamesh1997 reopened this Jul 11, 2025

Android: fixed internal review points

1655cb4

Sangamesh1997 added 2 commits July 14, 2025 03:20

Merge branch 'grpc:master' into Issue_fixed_12142

513c4d5

Android: worked on lint and build warnings

356f345

Sangamesh1997 requested a review from kannanjgithub July 14, 2025 09:37

Merge branch 'grpc:master' into Issue_fixed_12142

f9e6703

ejona86 reviewed Jul 28, 2025

View reviewed changes

Android: Clean up lint warnings and other warnings to get build success #12143

Are you sure you want to change the base?

Android: Clean up lint warnings and other warnings to get build success #12143

Conversation

Sangamesh1997 commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sangamesh1997 commented Jun 19, 2025

Uh oh!

kannanjgithub commented Jun 19, 2025

Uh oh!

Sangamesh1997 commented Jun 19, 2025

Uh oh!

kannanjgithub commented Jun 19, 2025

Uh oh!

Sangamesh1997 commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shivaspeaks left a comment

Choose a reason for hiding this comment

Uh oh!

Sangamesh1997 commented Jun 20, 2025

Uh oh!

kannanjgithub commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kannanjgithub Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kannanjgithub Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sangamesh1997 commented Jul 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdcormie Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Sangamesh1997 commented Jun 10, 2025 •

edited

Loading

Sangamesh1997 commented Jun 19, 2025 •

edited

Loading

kannanjgithub commented Jul 10, 2025 •

edited

Loading

kannanjgithub Jul 10, 2025 •

edited

Loading

kannanjgithub Jul 10, 2025 •

edited

Loading

jdcormie Jul 29, 2025 •

edited

Loading