-
Notifications
You must be signed in to change notification settings - Fork 3.9k
xds: Envoy proto sync to #12224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xds: Envoy proto sync to #12224
Conversation
Note: I added cidr.proto that's in xds and address.proto myself. import.sh didn't add it and then it was failing for files not found. |
import.sh has a list of files to import. grpc-java/xds/third_party/envoy/import.sh Line 26 in d352540
|
Oh we have a different import.sh for xds protos. So we need to update import new version from xds OSS in a same way? Is there any rulebook or some process to follow? Maybe we should be doing both imports in separate PRs. |
It wouldn't be weird to upgrade the "xds" and "envoy" protos at the same time. You might need to upgrade even more than that at once to get everything working together. |
Oh I didn't see your comment here, and I was already working and created a PR for xds proto import: #12225 |
envoyproxy/envoy: Sync protos to the latest imported version envoyproxy/envoy@1128a52 (commit 2025-06-18).
Should be a noop, just a routine xDS proto update.