Skip to content

Conversation

@ratnikov
Copy link

@ratnikov ratnikov commented Jun 8, 2024

Resolves #398

I'm open to which version to pick, just happy I can depend on grpc-kotlin using bazel mod. :)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 8, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@ed-irl
Copy link

ed-irl commented Jul 19, 2024

@ratnikov I was just lurking on the issue that this patch is targeted towards. Is there an alternative/competing patch thats not listed on the issue? Nice work regardless, it would be good to see bzlmod support. Hopefully you're able to get the CLA and stuff and find a reviewer 😄 🤞

@ratnikov
Copy link
Author

I'm not aware of any alternative work. I've been using my patch internally for a bit, so so far it works. :)

We've been making some progress on our end to get the EasyCLA hurdle out of the way, so I'm hopping that that will be green in a week or two. I have a feeling that may elicit some input from maintainers on its mergability.

@gonzojive
Copy link

Is anything blocking review of this? It seems the CLA has been signed.

@ratnikov
Copy link
Author

@lowasser hey, looks like you merged last few commits. Could you help me understand what's the best process to follow to proceed with the review of this PR?

@gonzojive
Copy link

Ready to merge?

@ratnikov
Copy link
Author

@gonzojive Yes. Waiting for maintainers to take action and unblock running of the checks (or unblock merging in a different way).

@blockjon-dd
Copy link

blockjon-dd commented Jan 3, 2025

👋 bzlmod user here. I tried the techniques seen here in my project and things seem like they are working. Thanks for the great work.

@cgruber
Copy link

cgruber commented Mar 13, 2025

@lowasser - Any movement on this? (also, hi!)

@stack-plumber
Copy link

@ratnikov Thanks for this work. (bzlmod user here and also blaze user as I am a Googler :P) . Eagerly waiting for this PR to be merged from past few months. I can use the same tech-stack which I am currently used-to in Google for fullstack development.

@dougthor42
Copy link

Friendly /poke from another googler. 👋

@jack-bradshaw
Copy link

Is this going ahead? Bazel 9 is coming and soon workspace will not be feasible at all.

@duckladydinh
Copy link
Collaborator

Hey everyone - some good news. Initial bzlmod support has now been merged. Definitely, a huge thanks to @ratnikov for getting the ball rolling on this, and to everyone here for pushing it forward. While not merged, part of the info in this PR were definitely reflected in #640. Right now, you can test it with something like:

bazel_dep(name = "grpc_kotlin", version = "0.0.0")

git_override(
    module_name = "grpc_kotlin",
    commit = "de050e0bbef2c8acc1050697a0ee39afcf651858",
    remote = "https://github.com/grpc/grpc-kotlin.git",
)

As you may have guessed, the real maintainers are fully occupied with their primary work. To clarify, I am not real maintainer, but just have temporary permissions :). I would like to see this to the end, hopefully getting it released to the Bazel registry.

In the meantime (probably the next 1-2-3 weekends), while I can't approve my own PRs (so hard to make things better on my own), I can review yours =)). if you see some bugs or improvements and willing and able to make some very simple and short changes that can be quickly verified, I am happy to review and merge them to make this better. Especially @ratnikov, I'll prioritize your PRs if any. ;) Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for Bzlmod

10 participants