-
Couldn't load subscription status.
- Fork 178
Add support for accessing gRPC Metadata in RPC implementation code. #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add support for accessing gRPC Metadata in RPC implementation code. #729
Conversation
stub/src/main/java/io/grpc/kotlin/MetadataCoroutineContextInterceptor.kt
Outdated
Show resolved
Hide resolved
stub/src/main/java/io/grpc/kotlin/MetadataCoroutineContextInterceptor.kt
Show resolved
Hide resolved
stub/src/test/java/io/grpc/kotlin/MetadataCoroutineContextInterceptorTest.kt
Outdated
Show resolved
Hide resolved
stub/src/test/java/io/grpc/kotlin/MetadataCoroutineContextInterceptorTest.kt
Outdated
Show resolved
Hide resolved
stub/src/test/java/io/grpc/kotlin/MetadataCoroutineContextInterceptorTest.kt
Outdated
Show resolved
Hide resolved
stub/src/test/java/io/grpc/kotlin/MetadataCoroutineContextInterceptorTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to update you, my next review will be next Wednesday, I am OOO now :).
stub/src/test/java/io/grpc/kotlin/MetadataCoroutineContextInterceptorTest.kt
Outdated
Show resolved
Hide resolved
stub/src/test/java/io/grpc/kotlin/MetadataCoroutineContextInterceptorTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I agree that this metadata is quite a useful thing to have and especially given that grpc rust also has it. So we will just format the CL to Google Style and we can merge it.
BUT... pls note that we can merge but for this type of change, we need to wait for the real admins to release :) because I am not sure if the authors want to get into the business of providing a set of reusable interceptors and if they do, maybe they should be in some package like io.grpc.kotlin.interceptors or something. If we make a release now, it will be fixated on the current path. That's why I'll merge but I'll leave the release to the admins to leave room for modification and restructuring.
And my next review will wait a bit longer btw.
stub/src/main/java/io/grpc/kotlin/MetadataCoroutineContextInterceptor.kt
Outdated
Show resolved
Hide resolved
stub/src/test/java/io/grpc/kotlin/MetadataCoroutineContextInterceptorTest.kt
Outdated
Show resolved
Hide resolved
stub/src/test/java/io/grpc/kotlin/MetadataCoroutineContextInterceptorTest.kt
Outdated
Show resolved
Hide resolved
Valid concern! Let's me clarify the goal for avoiding the confusion. The goal is accessing Currently, I see 2 ways for achieving that:
|
This is for accessing gRPC Metadata in RPC implementation code.
Usage:
MetadataCoroutineContextInterceptorto gRPC server.grpcMetadata()for accessing RPC request's Metadata.