Skip to content

Fix server keep alive timeout not properly destroying connections #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix server keep alive timeout not properly destroying connections #3022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/grpc-js/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1609,7 +1609,7 @@ export class Server {
if (err) {
this.keepaliveTrace('Ping failed with error: ' + err.message);
sessionClosedByServer = true;
session.close();
session.destroy();
} else {
this.keepaliveTrace('Received ping response');
maybeStartKeepalivePingTimer();
Expand All @@ -1631,7 +1631,7 @@ export class Server {
'Connection dropped due to ping send error: ' + pingSendError
);
sessionClosedByServer = true;
session.close();
session.destroy();
return;
}

Expand All @@ -1640,7 +1640,7 @@ export class Server {
this.keepaliveTrace('Ping timeout passed without response');
this.trace('Connection dropped by keepalive timeout');
sessionClosedByServer = true;
session.close();
session.destroy();
}, this.keepaliveTimeoutMs);
keepaliveTimer.unref?.();
};
Expand Down Expand Up @@ -1803,7 +1803,7 @@ export class Server {
duration
);
sessionClosedByServer = true;
session.close();
session.destroy();
} else {
this.keepaliveTrace('Received ping response');
maybeStartKeepalivePingTimer();
Expand All @@ -1826,7 +1826,7 @@ export class Server {
'Connection dropped due to ping send error: ' + pingSendError
);
sessionClosedByServer = true;
session.close();
session.destroy();
return;
}

Expand All @@ -1840,7 +1840,7 @@ export class Server {
'Connection dropped by keepalive timeout from ' + clientAddress
);
sessionClosedByServer = true;
session.close();
session.destroy();
}, this.keepaliveTimeoutMs);
keepaliveTimeout.unref?.();
};
Expand Down