Skip to content

Ring hash fix for affinity test #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 3, 2025
Merged

Ring hash fix for affinity test #211

merged 10 commits into from
Nov 3, 2025
+20 −2

Conversation

@pawbhard
Copy link
Contributor

@pawbhard pawbhard commented Oct 30, 2025 •
edited
Loading

Start a temporary client to verify all endpoints are reported by TD.
This is to address flakiness where the main client starts with a partial list of endpoints. Causing issue with RING_HASH no of sub channel validations

Bug b/374693206

@pawbhard pawbhard changed the title Ring hash try Ring hash fix for affinity test Oct 30, 2025
@pawbhard pawbhard marked this pull request as ready for review October 30, 2025 14:44
@pawbhard pawbhard requested a review from a team as a code owner October 30, 2025 14:44
sergiitk
sergiitk reviewed Oct 30, 2025
View reviewed changes
@pawbhard
Copy link
Contributor Author

grpc/core/v1.72.x/branch/linux/psm-dualstack-python

@pawbhard
Copy link
Contributor Author

Latest run : grpc/core/v1.72.x/branch/linux/psm-dualstack-python

@pawbhard pawbhard requested a review from sergiitk October 31, 2025 03:42
@sergiitk
Copy link
Member

sergiitk commented Nov 3, 2025

Great! Compare with the past run (grpc/core/v1.72.x/branch/linux/psm-dualstack-python), reusing the namespace saved us more than 4 minutes!

$ human-sec 880.019s
Out[1]: '14 minutes and 40.02 seconds'
$ human-sec 606.581s
Out[1]: '10 minutes and 6.58 seconds'

@sergiitk sergiitk merged commit 959adaa into grpc:main Nov 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergiitk sergiitk sergiitk approved these changes

@kannanjgithub kannanjgithub Awaiting requested review from kannanjgithub

@eshitachandwani eshitachandwani Awaiting requested review from eshitachandwani

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pawbhard @sergiitk