Use location-specific opac.barcode_regex#2
Open
jeff wants to merge 1 commit intogrpl-eg:masterfrom
Open
Conversation
Instead of fetching the opac.barcode_regex setting based on globalOrgTree.id(), use the value of getLocation(). This is useful in situations where a system within a consortium uses a different barcode regex than the rest of the consortium.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code affects all skins, but should not cause any issues unless there are incorrect opac.barcode_regex OU settings sitting around.
The change will not take effect until autogen.sh is run to re-create the various combined.js files like opac/skin/tadl/js/combined.js
commit message follows:
Instead of fetching the opac.barcode_regex setting based on
globalOrgTree.id(), use the value of getLocation().
This is useful in situations where a system within a consortium
uses a different barcode regex than the rest of the consortium.