Skip to content

cam 1 & 2 construction and nt table camera selectr #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tonyxwu wants to merge 60 commits into
base: main
Choose a base branch
from
Open

cam 1 & 2 construction and nt table camera selectr #20

Tonyxwu wants to merge 60 commits into from

Conversation

@Tonyxwu
Copy link
Contributor

@Tonyxwu Tonyxwu commented Feb 26, 2025

No description provided.

@Tonyxwu Tonyxwu requested a review from 6kn4eakfr4s February 26, 2025 19:26
6kn4eakfr4s
6kn4eakfr4s approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@6kn4eakfr4s 6kn4eakfr4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

6kn4eakfr4s and others added 26 commits February 26, 2025 19:59
@6kn4eakfr4s @CrolineCrois
Update krakens to torque current FOC control
28c15cb
@6kn4eakfr4s @CrolineCrois
Add debug constant
9208dd9
@6kn4eakfr4s @CrolineCrois
Publishes & logs close loop error
5a6dcb6
@6kn4eakfr4s @CrolineCrois
Fix naming
97dd677
@6kn4eakfr4s @CrolineCrois
publish & log closed loop error
3b08fd4
@6kn4eakfr4s @CrolineCrois
Untested Kraken Intake
b00b241
@6kn4eakfr4s @CrolineCrois
Remove the second log call in periodic
386856c
@6kn4eakfr4s @CrolineCrois
Make pivot ready to test
11b7284
@6kn4eakfr4s @CrolineCrois
Add methods to allow voltage requests to account for motor not under …
6e3b733 
…canivore
@6kn4eakfr4s @CrolineCrois
Using voltage requests instead of torque current FOC requests to acco…
9c5123f 
…unt for motor not under canivore
@6kn4eakfr4s @CrolineCrois
Added more intake commands to test and bind them in a seperate method
5789cf4
@6kn4eakfr4s @CrolineCrois
Force the drive controller to be PS5 controller
795c922
@6kn4eakfr4s @CrolineCrois
Make pivot ready to test
fd6639f
@6kn4eakfr4s @CrolineCrois
Make pivot ready to test
be5c04c
@6kn4eakfr4s @CrolineCrois
Onlyuse mech controller joystick to control pivot when its reading is…
2c3b4fc 
… greater than deadzone
@6kn4eakfr4s @CrolineCrois
Change set reference methods to set reference with velocity requests
99e3c78
@swaswa999 @CrolineCrois
setPositionReference
b612863
@CrolineCrois
intake tested and tuned
494e1ff
@CrolineCrois
working conversion factor for pivot
008434b
@6kn4eakfr4s @CrolineCrois
Allow setting current and duty cycle requests
d272166
@6kn4eakfr4s @CrolineCrois
Added logged boolean sensor
e50558a
@6kn4eakfr4s @CrolineCrois
Make pivot ready to test
bc533db
@6kn4eakfr4s @CrolineCrois
Remove extra lines from rebasing
0a99358
@CrolineCrois
tuned pivot
33507c6
@CrolineCrois
t:wq
c0265fe 
retune
@CrolineCrois
Merge pull request #22 from grt192/kraken-intake-v2
03892ba 
Kraken intake v2
6kn4eakfr4s and others added 30 commits February 26, 2025 21:32
@6kn4eakfr4s @CrolineCrois
Publishes & logs close loop error
7f913fb
@6kn4eakfr4s @CrolineCrois
Fix naming
dd89d96
@6kn4eakfr4s @CrolineCrois
publish & log closed loop error
b5c54e9
@6kn4eakfr4s @CrolineCrois
Untested Elevator
2fc2ecf
@6kn4eakfr4s @CrolineCrois
make elevator ready to test
b125663
@6kn4eakfr4s @CrolineCrois
Force the drive controller to be PS5 controller
8c09de4
@6kn4eakfr4s @CrolineCrois
Force the drive controller to be PS5 controller
3996ae5
@6kn4eakfr4s @CrolineCrois
Bind elevator in seperate method
b84f4e1
@CrolineCrois
fix imports after rebase
d083dbd
@CrolineCrois
elevator mid-tune
3c801fd
@CrolineCrois
elevator tuned except the mech is ass bc the pullye derials so they a…
5ad39b3 
…re redoing them tomorrow
@6kn4eakfr4s @CrolineCrois
Change package paths back to Commands
5b560a3
@6kn4eakfr4s @CrolineCrois
Add methods to allow voltage requests to account for motor not under …
63f247c 
…canivore
@6kn4eakfr4s @CrolineCrois
Allow setting current and duty cycle requests
e6d78ff
@CrolineCrois
Merge branch 'pinnacles' into elevator-v2
a0c9ec3
@CrolineCrois
fix build issues
d3ee1a6
@CrolineCrois
Merge pull request #23 from grt192/elevator-v2
530953b 
Elevator v2
@6kn4eakfr4s
Publish & Log target duty cycle and torque current foc.
248ef35
@6kn4eakfr4s
Use logged boolean sensor & allow set duty cycle power
35fe899
@6kn4eakfr4s
Tuned Elevator, Intake, Pivot Constants
0c64c0e
@6kn4eakfr4s
Disable soft limit, add methods allowing setting duty cycle, torque c…
a959bc4 
…urrent, and position
@6kn4eakfr4s
Use logged limit switch, disable soft limit, allow set duty cycle and…
be2a948 
… torque current
@6kn4eakfr4s
Added command to make rollers run till distance sensor detects
8ea31eb
@6kn4eakfr4s
Stop intake command when there is a corral in
b2da615
@6kn4eakfr4s
Rewrite elevator to limit switch command so it stops by limit switch
eb96cb9
@6kn4eakfr4s
Command to zero pivot to 90 degrees
25f54bc
@6kn4eakfr4s
Bind commands based on Lucca's suggestions
d81aaa4
@6kn4eakfr4s
Remove unused PS5 mech controller
bae628b
@6kn4eakfr4s
Merge branch 'pinnacles' into 2-camera--stuff
f5b4091
@6kn4eakfr4s
Remove unused subsystems
c001f3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@6kn4eakfr4s 6kn4eakfr4s 6kn4eakfr4s approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Tonyxwu @6kn4eakfr4s @swaswa999 @CrolineCrois