OpenBIOS: Add ZN-1 support (and lay the groundwork for ZN-2 support) #1987
CodeScene PR Check
Quality Gate Failed
Gates Failed
(2 files with Large Method, Complex Method)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| misc.c | 1 advisory rule | 10.00 → 9.61 | Suppress |
| main.c | 1 advisory rule | 7.34 → 7.33 | Suppress |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Large Method main.c: boot
- Complex Method misc.c: getSystemInfo
✅ Improving Code Health:
- Overall Code Complexity main.c
Annotations
Check warning on line 359 in src/mips/openbios/main/main.c
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ Getting worse: Large Method
boot increases from 102 to 104 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check notice on line 1 in src/mips/openbios/main/main.c
codescene-delta-analysis / CodeScene Code Health Review (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.69 to 4.50, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check warning on line 96 in src/mips/openbios/kernel/misc.c
codescene-delta-analysis / CodeScene Code Health Review (main)
❌ New issue: Complex Method
getSystemInfo has a cyclomatic complexity of 14, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.