Fix: Apply 10-second default timeout when Client() called without timeout parameter#130
Merged
gtsystem merged 2 commits intogtsystem:masterfrom Jan 7, 2026
Merged
Conversation
Owner
|
Thanks for reporting. It seems a similar issue was already present before the recent refactoring and was probably not cached due to the error in the test suite that is now failing. Can you also adapt the tests? |
Contributor
Author
Done! |
Owner
|
Fix released as lightkube version 0.19.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
Client()is instantiated without atimeoutparameter,timeout=Noneis explicitly passed toConnectionParams, preventing the dataclassdefault_factoryfrom activating. This causes HTTP operations to hang indefinitely.Solution
Explicitly set
timeout = httpx.Timeout(10.0)whentimeout is Nonein bothClientandAsyncClientconstructors, ensuring the documented 10-second default is applied.