fix(riff-raff-generator): Correctly add minInstancesInServiceParameters parameter#2764
fix(riff-raff-generator): Correctly add minInstancesInServiceParameters parameter#2764
minInstancesInServiceParameters parameter#2764Conversation
|
akash1810
force-pushed
the
aa/refactor-singleton
branch
from
17466b0 to
a8f33db
Compare
|
This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days |
akash1810
force-pushed
the
aa/refactor-singleton
branch
from
a8f33db to
87eb1bf
Compare
akash1810
force-pushed
the
aa/refactor-singleton
branch
from
87eb1bf to
e931d1d
Compare
|
This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days |
|
This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days |
akash1810
force-pushed
the
aa/refactor-singleton
branch
from
e931d1d to
152d525
Compare
`Construct` is a shared base type; use that to simplify some code.
akash1810
force-pushed
the
aa/refactor-singleton
branch
11 times, most recently
from
942ccbe to
1482886
Compare
…rviceParameters` deployment parameter
…instantiation within `GuRoot`
Remove nested conditional spread operations in favour of `if` statements.
See https://github.com/aws/constructs/blob/c2298f1bf89a701e1d501f279aa71d7d33b91c2b/src/construct.ts#L497-L519, which recommends using user-defined type guards over `instanceof`. `CfnScalingPolicy` is an auto-generated class by `aws-cdk-lib`. The `isCfnScalingPolicy` function is an auto-generated user-defined type guard.
akash1810
force-pushed
the
aa/refactor-singleton
branch
3 times, most recently
from
b9e5844 to
22eedc8
Compare
…ly when necessary Set `minInstancesInServiceParameters` if the `stack` has an instance of `GuHorizontallyScalingDeploymentPropertiesExperimental` added to it, rather than calling `getInstance` which will instantiate a `GuHorizontallyScalingDeploymentPropertiesExperimental` if it doesn't exist.
akash1810
force-pushed
the
aa/refactor-singleton
branch
from
22eedc8 to
4c2e594
Compare
1 participant
What does this change?
How to test
How can we measure success?
Have we considered potential risks?
Checklist
Footnotes
Consider whether this is something that will mean changes to projects that have already been migrated, or to the CDK CLI tool. If changes are required, consider adding a checklist here and/or linking to related PRs. ↩
If you are adding a new construct or pattern, has new documentation been added? If you are amending defaults or changing behaviour, are the existing docs still valid? ↩