Skip to content

Add devenv support and tool versions#2853

Open
aug24 wants to merge 4 commits intomainfrom
add-devenv-support-and-tool-versions
Open

Add devenv support and tool versions#2853
aug24 wants to merge 4 commits intomainfrom
add-devenv-support-and-tool-versions

Conversation

@aug24
Copy link
Contributor

@aug24 aug24 commented Mar 6, 2026

What does this change?

This PR provides definition files to enable development inside a dev container.

How to test

How can we measure success?

Have we considered potential risks?

Checklist

  • I have listed any breaking changes, along with a migration path 1
  • I have updated the documentation as required for the described changes 2

Footnotes

  1. Consider whether this is something that will mean changes to projects that have already been migrated, or to the CDK CLI tool. If changes are required, consider adding a checklist here and/or linking to related PRs.

  2. If you are adding a new construct or pattern, has new documentation been added? If you are amending defaults or changing behaviour, are the existing docs still valid?

@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2026

⚠️ No Changeset found

Latest commit: c7dd1e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aug24 aug24 added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Mar 6, 2026
Copy link
Member

@akash1810 akash1810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some instructions in contributing.md detailing how one might use the dev container?

.tool-versions Outdated
@@ -0,0 +1 @@
node 22.16.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's replace the .nvmrc file to maintain a single source of truth? I imagine the GitHub workflows would also need updating, for example:

node-version-file: ".nvmrc"
.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something's happened and this change was lost, but I just wanted to second this. Standardising on .tool-versions and removing all other files would be great!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all the comments in this file necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is standard text that the devenv tool outputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants