Conversation
|
akash1810
left a comment
There was a problem hiding this comment.
Could we add some instructions in contributing.md detailing how one might use the dev container?
.tool-versions
Outdated
| @@ -0,0 +1 @@ | |||
| node 22.16.0 | |||
There was a problem hiding this comment.
Let's replace the .nvmrc file to maintain a single source of truth? I imagine the GitHub workflows would also need updating, for example:
Line 12 in 3a1e3a7
There was a problem hiding this comment.
I think something's happened and this change was lost, but I just wanted to second this. Standardising on .tool-versions and removing all other files would be great!
There was a problem hiding this comment.
Are all the comments in this file necessary?
There was a problem hiding this comment.
This is standard text that the devenv tool outputs
What does this change?
This PR provides definition files to enable development inside a dev container.
How to test
How can we measure success?
Have we considered potential risks?
Checklist
Footnotes
Consider whether this is something that will mean changes to projects that have already been migrated, or to the CDK CLI tool. If changes are required, consider adding a checklist here and/or linking to related PRs. ↩
If you are adding a new construct or pattern, has new documentation been added? If you are amending defaults or changing behaviour, are the existing docs still valid? ↩