Skip to content

Rework the footer component to simplify rendering logic #15323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cemms1 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Rework the footer component to simplify rendering logic #15323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
223 changes: 39 additions & 184 deletions dotcom-rendering/src/components/Card/Card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
import { css } from '@emotion/react';
import { isUndefined } from '@guardian/libs';
import { between, from, space, until } from '@guardian/source/foundations';
import { Hide, Link, SvgCamera } from '@guardian/source/react-components';
import { Hide } from '@guardian/source/react-components';
import {
ArticleDesign,
type ArticleFormat,
ArticleSpecial,
} from '../../lib/articleFormat';
import { isMediaCard } from '../../lib/cardHelpers';
import { isWithinTwelveHours, secondsToDuration } from '../../lib/formatTime';
import { secondsToDuration } from '../../lib/formatTime';
import { appendLinkNameMedia } from '../../lib/getDataLinkName';
import { getZIndex } from '../../lib/getZIndex';
import { getOphanComponents } from '../../lib/labs';
import { DISCUSSION_ID_DATA_ATTRIBUTE } from '../../lib/useCommentCount';
import { BETA_CONTAINERS } from '../../model/enhanceCollections';
import { palette } from '../../palette';
import type { Branding } from '../../types/branding';
Expand All @@ -31,7 +30,6 @@ import type { MainMedia } from '../../types/mainMedia';
import type { OnwardsSource } from '../../types/onwards';
import { Avatar } from '../Avatar';
import { BrandingLabel } from '../BrandingLabel';
import { CardCommentCount } from '../CardCommentCount.importable';
import { CardHeadline, type ResponsiveFontSize } from '../CardHeadline';
import type { Loading } from '../CardPicture';
import { CardPicture } from '../CardPicture';
Expand All @@ -50,8 +48,7 @@ import { SupportingKeyStoriesContent } from '../SupportingKeyStoriesContent';
import { SvgMediaControlsPlay } from '../SvgMediaControlsPlay';
import { YoutubeBlockComponent } from '../YoutubeBlockComponent.importable';
import { AvatarContainer } from './components/AvatarContainer';
import { CardAge } from './components/CardAge';
import { CardFooter } from './components/CardFooter';
import { CardFooter } from './components/CardFooterNew';
import {
CardLayout,
decideAvatarPosition,
Expand Down Expand Up @@ -337,14 +334,6 @@ const decideSublinkPosition = (
return alignment === 'vertical' ? 'inner' : 'outer';
};

const liveBulletStyles = css`
width: 9px;
height: 9px;
border-radius: 50%;
background-color: ${palette('--pill-bullet')};
margin-right: ${space[1]}px;
`;
Comment on lines -340 to -346
Copy link
Contributor Author

@cemms1 cemms1 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO - include this in card footer


export const Card = ({
linkTo,
format,
Expand Down Expand Up @@ -431,143 +420,6 @@ export const Card = ({
*/
const isVideoArticle = format.design === ArticleDesign.Video;

const isLabs = format.theme === ArticleSpecial.Labs;

const decideAge = () => {
if (!webPublicationDate) return undefined;
const withinTwelveHours = isWithinTwelveHours(webPublicationDate);

const shouldShowAge =
isStorylines ||
isTagPage ||
!!onwardsSource ||
(showAge && withinTwelveHours);

if (!shouldShowAge) return undefined;

return (
<CardAge
webPublication={{
date: webPublicationDate,
isWithinTwelveHours: withinTwelveHours,
}}
showClock={showClock}
serverTime={serverTime}
isTagPage={isTagPage}
/>
);
};

const CommentCount = () =>
!!discussionId && (
<Link
{...{
[DISCUSSION_ID_DATA_ATTRIBUTE]: discussionId,
}}
data-ignore="global-link-styling"
data-link-name="Comment count"
href={`${linkTo}#comments`}
cssOverrides={css`
/* See: https://css-tricks.com/nested-links/ */
z-index: ${getZIndex('card-nested-link')};
/* The following styles turn off those provided by Link */
color: inherit;
/* stylelint-disable-next-line property-disallowed-list */
font-family: inherit;
font-size: inherit;
line-height: inherit;
text-decoration: none;
min-height: 10px;
`}
>
<Island priority="feature" defer={{ until: 'visible' }}>
<CardCommentCount
discussionApiUrl={discussionApiUrl}
discussionId={discussionId}
/>
</Island>
</Link>
);

const MediaOrNewsletterPill = () => (
<div
css={css`
margin-top: auto;
display: flex;
${isStorylines &&
`
flex-direction: column;
gap: ${space[1]}px;
align-items: flex-start;
`}
`}
>
{/* Usually, we either display the pill or the footer,
but if the card appears in the storylines section on tag pages
then we do want to display the date on these cards as well as the media pill.
*/}
{isStorylines && (
<CardFooter
format={format}
age={decideAge()}
commentCount={<CommentCount />}
cardBranding={
isOnwardContent ? <LabsBranding /> : undefined
}
showLivePlayable={showLivePlayable}
/>
)}

{mainMedia?.type === 'YoutubeVideo' && isVideoArticle && (
<>
{mainMedia.isLive ? (
<Pill
content="Live"
icon={<div css={liveBulletStyles} />}
/>
) : (
<Pill
content={secondsToDuration(mainMedia.duration)}
icon={<SvgMediaControlsPlay width={18} />}
prefix="Video"
/>
)}
</>
)}
{mainMedia?.type === 'Audio' && (
<Pill
content={mainMedia.duration}
icon={<SvgMediaControlsPlay width={18} />}
prefix="Podcast"
/>
)}
{mainMedia?.type === 'Gallery' && (
<Pill
content={mainMedia.count}
icon={<SvgCamera />}
prefix="Gallery"
/>
)}
{mainMedia?.type === 'SelfHostedVideo' &&
(format.design === ArticleDesign.Video ? (
<Pill
content=""
icon={<SvgMediaControlsPlay width={18} />}
prefix="Video"
/>
) : format.design === ArticleDesign.Audio ? (
<Pill
content=""
icon={<SvgMediaControlsPlay width={18} />}
prefix="Podcast"
/>
) : format.design === ArticleDesign.Gallery ? (
<Pill content="" icon={<SvgCamera />} prefix="Gallery" />
) : null)}
{isNewsletter && <Pill content="Newsletter" />}
</div>
);

if (snapData?.embedHtml) {
return (
<SnapCssSandbox snapData={snapData}>
Expand Down Expand Up @@ -873,7 +725,7 @@ export const Card = ({
alignment="end"
ophanComponentLink={dataAttributes?.ophanComponentLink}
ophanComponentName={dataAttributes?.ophanComponentName}
isLabs={isLabs}
isLabs={format.theme === ArticleSpecial.Labs}
dataTestId="card-branding-logo"
/>
</div>
Expand All @@ -896,7 +748,7 @@ export const Card = ({
alignment="end"
ophanComponentLink={dataAttributes?.ophanComponentLink}
ophanComponentName={dataAttributes?.ophanComponentName}
isLabs={isLabs}
isLabs={format.theme === ArticleSpecial.Labs}
/>
</div>
</>
Expand Down Expand Up @@ -1300,33 +1152,28 @@ export const Card = ({
/>
)}

{/** Footer rendered inside the card boundary */}
{!isOpinionCardWithAvatar && (
<>
{showPill ? (
<>
{!!branding &&
format.theme ===
ArticleSpecial.Labs &&
isOnwardContent && (
<LabsBranding />
)}
<MediaOrNewsletterPill />
</>
) : (
<CardFooter
format={format}
age={decideAge()}
commentCount={<CommentCount />}
cardBranding={
isOnwardContent ? (
<LabsBranding />
) : undefined
}
showLivePlayable={showLivePlayable}
/>
)}
</>
<CardFooter
format={format}
showLivePlayable={showLivePlayable}
showAge={showAge}
cardBranding={<LabsBranding />}
mainMedia={mainMedia}
isNewsletter={isNewsletter}
showPill={showPill}
isStorylines={isStorylines}
onwardsSource={onwardsSource}
webPublicationDate={webPublicationDate}
showClock={showClock}
serverTime={serverTime}
isTagPage={isTagPage}
discussionId={discussionId}
discussionApiUrl={discussionApiUrl}
linkTo={linkTo}
/>
)}

{showLivePlayable &&
liveUpdatesPosition === 'inner' && (
<Island
Expand Down Expand Up @@ -1413,20 +1260,28 @@ export const Card = ({
{isOpinionCardWithAvatar && (
<CardFooter
format={format}
age={decideAge()}
commentCount={<CommentCount />}
showLivePlayable={showLivePlayable}
showAge={showAge}
cardBranding={<LabsBranding />}
mainMedia={mainMedia}
isNewsletter={isNewsletter}
shouldReserveSpace={{
mobile: avatarPosition.mobile === 'bottom',
desktop: avatarPosition.desktop === 'bottom',
}}
showPill={showPill}
isStorylines={isStorylines}
onwardsSource={onwardsSource}
webPublicationDate={webPublicationDate}
showClock={showClock}
serverTime={serverTime}
isTagPage={isTagPage}
discussionId={discussionId}
discussionApiUrl={discussionApiUrl}
linkTo={linkTo}
/>
)}
</div>

{!isOnwardContent && format.theme === ArticleSpecial.Labs && (
<LabsBranding />
)}
</CardWrapper>
);
};
Loading
Loading