Add .element-video-immersive to immersive self-hosted videos#15396
Open
simonbyford wants to merge 1 commit intomainfrom
Open
Add .element-video-immersive to immersive self-hosted videos#15396simonbyford wants to merge 1 commit intomainfrom
.element-video-immersive to immersive self-hosted videos#15396simonbyford wants to merge 1 commit intomainfrom
Conversation
simonbyford
force-pushed
the
add-immersive-class
branch
from
b15920a to
9662330
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds
.element-video-immersiveto self-hosted videos withrole = immersiveRelies on guardian/frontend#28616
Why?
Requested by Harry Fischer. We already do it for immersive images.
How to test
Deploy this branch and guardian/frontend#28616 to CODE. Create an article containing a self-hosted video with weighting set to "Immersive". Preview the article. The
figurecontaining the video should have classelement-video-immersive.Screenshots