Open
Conversation
d802015 to
c763385
Compare
The phone number library now supports the feature we need
72e8bac to
497d612
Compare
The java.net.URL implementation always does DNS resolution, which is bad when it's mostly used for its URL parsing ability. URI should be used for that
Contributor
Contributor
Author
|
smoke tested in CODE ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the project to java 21
I've had to do a few things following the move to java 21:
nullin places that didn't return null on java.net.URL, so we'll keep an eye on the logs after releasing this