Send browserId to /consent-signup endpoint in IDAPI#28613
Open
Send browserId to /consent-signup endpoint in IDAPI#28613
/consent-signup endpoint in IDAPI#28613Conversation
This is the endpoint that gets hit when a user subscribes to newsletter without email confirmation
ioannakok
force-pushed
the
send-browser-id-to-idapi
branch
from
a484bc3 to
8aa753d
Compare
Contributor
ioannakok
changed the title
/consent-signup in IDAPI/consent-signup endpoint in IDAPI
AshCorr
approved these changes
Feb 18, 2026
| s"Post request received to /email/ - " + | ||
| s"ref: ${form.ref}, " + | ||
| s"refViewId: ${form.refViewId}, " + | ||
| s"browserId: ${form.browserId}, " + |
Member
There was a problem hiding this comment.
If this is a unique identifier would it be better to not log it?
Contributor
Author
There was a problem hiding this comment.
Yeah good point! I'm going to ask Emily tomorrow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR passes the browserId from DCR to IDAPI when the user subscribes to a single newsletter. This flow does not require email confirmation and gets triggered in:
Why?
Supporter Revenue have made a request to send them the user id, the newsletter id, the browser id and the timestamp when a user subscribes to a newsletter. Browser id is the only info we currently don't have.
Screenshots
BrowserId is undefined in CODE so we will have to merge this to see whether we actually send it.
Checklist
data/databasefiles generated by tests are committed with this PR (the tests will fail in CI if you've forgotten to do this)