Closed
Conversation
philmcmahon
added
maintenance
philmcmahon
force-pushed
the
use-java-21
branch
from
3c894ee to
7feaf2d
Compare
philmcmahon
force-pushed
the
brotli-java-21
branch
from
b6346af to
656d10b
Compare
philmcmahon
force-pushed
the
brotli-java-21
branch
from
656d10b to
037ad03
Compare
Contributor
Author
|
TODO: check cost of compression |
twrichards
approved these changes
Jan 28, 2026
Contributor
twrichards
left a comment
twrichards
left a comment
There was a problem hiding this comment.
that's a lovely reduction in data transfer and definitely useful for slow connections (e.g. my commute into London 😜 )
I think it would be worth measuring how much time that adds to the server (and client) but I think we could do this check by releasing this PR, I've recorded three loads of 17MB workspace...
Contributor
Author
|
Replaced by #520 - thanks for review though @twrichards ! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR introduces brotli compression to giant using https://github.com/guardian/play-brotli-filter
The main benefit will be that, for users on slow connections, we're sending a lot less data. For example there is a 75% reduction in the size of the workspaces JSON blob when opening this (large) workspace on playground: https://playground.pfi.gutools.co.uk/workspaces/794bff73-681c-4ab4-b821-d3bb47191a34
The main performance problem for workspaces isn't data transfer time so this won't result in drastic improvements to our larger workspaces unless a user is using a bad internet connection, but seems a nice change nevertheless
Depends on #501
How to test
Tested on playground - doesn't seem to cause any problems with viewing media/pdfs.