Always send failed transcription tasks to dead letter queue#506
Draft
philmcmahon wants to merge 2 commits intomainfrom
Draft
Always send failed transcription tasks to dead letter queue#506philmcmahon wants to merge 2 commits intomainfrom
philmcmahon wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
At the moment there is an issue in giant where transcription jobs fail because it can't read the file from S3. This is (I think) due to this thing #64
At the moment for some reason we don't move messages to the dead letter queue where something goes wrong during giant's processing of the message - only if the message itself is a 'transcription failure'
In theory, messages should end up in the dead letter queue anyway in this situation - why aren't they? Leaving this as a draft for further discussion tomorrow
How to test
todo...