Skip to content
This repository was archived by the owner on Oct 16, 2024. It is now read-only.

Add support for ESLint v9#79

Draft
gund wants to merge 1 commit intomasterfrom
feat/eslint-v9
Draft

Add support for ESLint v9#79
gund wants to merge 1 commit intomasterfrom
feat/eslint-v9

Conversation

@gund
Copy link
Copy Markdown
Owner

@gund gund commented Jan 8, 2024

Add support for ESLint v9 while maintaining backwards compatibility with all previously supported ESLint versions.

Closes #78

This PR is cannot be finished until:

@gund gund mentioned this pull request Jan 8, 2024
@gund gund added the dependencies Pull requests that update a dependency file label Jan 8, 2024
@piotr-cz
Copy link
Copy Markdown

piotr-cz commented Mar 9, 2024

@Noumanluckey8057
Copy link
Copy Markdown

@JoshuaKGoldberg
Copy link
Copy Markdown
Contributor

👋 @gund are you still planning on working on this soon?

@JoshuaKGoldberg
Copy link
Copy Markdown
Contributor

As in: I'm happy to hop in and write a PR, but don't want to step on your toes. 🙂

@liquidg3
Copy link
Copy Markdown

@JoshuaKGoldberg - thought I was commenting on this earlier 😂 - hoping you can hop in and get this over the line if @gund is tied up! Thanks to you both for the hard work!

@karlhorky
Copy link
Copy Markdown
Contributor

karlhorky commented May 17, 2024

@gund now that ESLint v9 is out and typescript-eslint/typescript-eslint#8211 is closed in upstream, would you consider finishing and publishing this PR? (or publishing a pre-release version?)

As an alternative, there is also apparently an open proposal in typescript-eslint about a new rule marking @deprecated as a problem:

AhmedBaset added a commit to AhmedBaset/eslint-plugin-deprecation that referenced this pull request Jul 20, 2024
@Pietrucci-Blacher
Copy link
Copy Markdown

Hi @gund, any updates about a future release for ESlint V9 ? 👀

@SimonSchick
Copy link
Copy Markdown

Hey @gund we are looking to move to eslint v9 but this is the only remaining plugin really holding us back.
Are there incentives we can offer to move this forward?

@karlhorky
Copy link
Copy Markdown
Contributor

karlhorky commented Aug 28, 2024

For anyone wanting a rule like the one included in eslint-plugin-deprecation with support for ESLint v9, you can also consider switching to the typescript-eslint rule @typescript-eslint/no-deprecated, which was released recently in typescript-eslint@8.3.0:

Diff:

-import deprecation from 'eslint-plugin-deprecation';

// ...

    plugins: {
      'eslint-comments': eslintComments,
-     deprecation: fixupPluginRules(
-       /** @type {import("eslint").ESLint.Plugin} */ (
-         /** @type {unknown} */ (deprecation)
-       ),
-     ),
    },

// ...

    rules: {
-     // Warn about usage of deprecated APIs
-     // https://github.com/gund/eslint-plugin-deprecation
-     'deprecation/deprecation': 'warn',
+     // Warn about usage of deprecated APIs
+     // https://typescript-eslint.io/rules/no-deprecated/
+     '@typescript-eslint/no-deprecated': 'warn',

Caveat: In my first testing, it felt like it may be slower than eslint-plugin-deprecation.

@SimonSchick
Copy link
Copy Markdown

This resolves this for us, ty.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ESLint v9 compatibility

9 participants