Sync with notepad-plus-plus/wingup #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrate ZipLib (https://bitbucket.org/wbenny/ziplib) into project Add -unzipTo & -clean to decompress and clean
Update change log
uninstall: tell user to restart Notepad++ - Gup.exe remove all - clean in batch - relaunch Notepad++ gup.exe -clean "appPath2Launch" "dest_folder" "fold1" "a fold2" "fold3" gup.exe -clean "c:\npp\notepad++.exe" "c:\temp\" "toto" "ti ti" "tata" update: tell user to restart Notepad++ - Gup.exe download - remove all in directory - unzip/clean in batch - relaunch Notepad++ gup.exe -unzip -clean "appPath2Launch" "dest_folder" "toto http://toto" "titi http://titi" "tata http://tata" gup.exe -unzip -clean "c:\npp\notepad++.exe" c:\temp\ "toto http://toto" "ti et ti http://titi" "tata http://tata" Install: GUp.exe download - create directory - unzip: one by one, no relaunch gup.exe -unzipTo c:\donho\notepad++\plugins "https://github.com/npp-plugins/mimetools/releases/download/v2.1/mimetools.v2.1.zip"
…hash while installation and update.
…ctely) responsability from Notepad++ to WinGup For the sake of retro-compatibility, change the way of plugin packaging: 1. The plugin DLL file should be placed at the root level of the ZIP file. 2. The root level of the ZIP file can also contain additional files (DLL files or data files needed by the plugin) and folders which will be copied to the users harddisk as well. 3. Everything what gets copied from the ZIP file will be stored under <Npp-installation-folder>\plugins\<plugin-name>.
…mplementation. Make plugin installation way as updating one: same arguments and same implementation.
If WinGup is launched with privilege rights (UAC), the application it launches will have the same right. This PR makes explorer, which always has user's restriction, launch the application to get rid of the relevation.
- added missing nullpointer checks - extended error message on hash mismatch with the expected and found hashes Close #5
It should be fixed once for all logically (except the leaf directory could still be treated as file). However, the logic doesn't exist in a nightmare, which is based on an unreliable unzip component.
Updated outdated github action versions. Close #80
Added missing " at 5.1.3 Make lines in accordance with english.xml for comparability. Close #84
Try to wait for the maintained Notepad++ app process exit before proceeding to the scheduled GUP operation. Fix notepad-plus-plus/notepad-plus-plus#16364 Fix notepad-plus-plus/notepad-plus-plus#15673 Fix notepad-plus-plus/notepad-plus-plus#11819 Fix notepad-plus-plus/notepad-plus-plus#9148 Close #82 + also fix the GUP logging (corrupted widechar output and some minor other stuff)
Close #16521
…d++ behind Disabling the "Never" Notepad++ Update Available dialog button, when there is not a Notepad++ app running to receive the inter-process NPPM_DISABLEAUTOUPDATE msg. Close #90
Close #87
…aram For the new feature of Notepad++: "Add option for updating Notepad++ on exit" (notepad-plus-plus/notepad-plus-plus#16626), Notepad++ should not be relaunched, because after closing Notepad++ then updating Notepad++, updated Notepad++ relaunch is not expected. In this commit We modify the installer parameter on the fly, according the présence of Notepad++ instance, to meet the both needs (updating on startup & on exit). Ref: https://github.com/notepad-plus-plus/notepad-plus-plus/pull/16626/files#r2155056335 Close #91
Update for MSGID_GOTODOWNLOADPAGETEXT & MSGID_CLOSEAPP Close #93
Add command line argument "-i" to override the setting "infoUrl" value. Close #97
Add a new command line argument to indicate the domain prefix of download URL. If the argument "-dDOMAIN_PREFIX" is provided but download URL doesn't contain the indicated prefix, the download file won't be processed and WinGUp will exit.
Add a additional note on the deprecation of original WinGUp.
Add options to verify the code signing certificate signature on downloaded file before running it.
If there's any error during the verification, WinGUp exit & downloaded file won't be run.
Added options:
-chkCertSig= : Enable signature check on downloaded binary with "-chkCertSig=yes".
Otherwise all the other "-chkCert*" options will be ignored.
-chkCertTrustChain : Enable signature trust chain verification.
-chkCertRevoc : Enable the verification of certificate revocation state.
-chkCertName= : Verify certificate name (quotes allowed for white-spaces).
-chkCertSubject= : Verify subject name (quotes allowed for white-spaces).
-chkCertKeyId= : Verify certificate key identifier.
-chkCertAuthorityKeyId= : Verify certificate authority key identifier.
Log the error automatically when the signature & cetification verification fails: 1. Write error log (the security part) into %LOCALUSERDATA%\WinGUp\log\securityError.log, and add "-errLogPath=" argument to make it overridable. 2. Add the download URL + sha256 value of the downloaded file in the log. 3. Log also if the download URL is not what we expected. Fix #98, close #100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.