Merged
Conversation
guregu
requested changes
Mar 4, 2025
Owner
guregu
left a comment
guregu
left a comment
There was a problem hiding this comment.
Hello, I think it's a good idea. Although cmp.Or exists, it won't always work.
I'll merge this if you add the methods/tests to the zero subpackage too. Their APIs need to match.
Owner
|
This is released as v6 now. Bumped the major version just to be safe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a new method:
ValueOrThis method is similar to
ValueOrZero, the difference is that it will return the value put in the parameter instead of zero.Is this method suitable for this library?