Open
Conversation
Co-authored-by: Omar Flores Grimontt <omar.flores@3dves.com>
…sing arrows to go to next photo the image doesn't change (#245) * remove node-sass, upgrade npm, add sass, update sass-loader config Note that node-sass is deprecated, and the version that was installed does not compile on arm64. Also updated README.md * upgrade react minor version * add image swapping demo * fix PhotoViewerWrapper so it loads a new image if the filePath prop changes and update the demo to show that the image can be swapped * 1.2.4-fix-photo-viewer.0 * 1.2.4-fix-photo-viewer.1 * do not minify, ship source map * 1.2.4-fix-photo-viewer.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.