added weasyprint as another pdf generator#96
Open
AdSkipper1337 wants to merge 1 commit intogutschilla:masterfrom
Open
added weasyprint as another pdf generator#96AdSkipper1337 wants to merge 1 commit intogutschilla:masterfrom
AdSkipper1337 wants to merge 1 commit intogutschilla:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey all,
hope this is not unwelcome, I was working on a pdf generation project and I was using your library.
However I noticed multiple issues with wkhtmltopdf and headless chrome, and I decided to evaluate weasyprint.
Well, since your library handles the overhead of including that really well and the code was easy to understand I took the liberty of just implementing the feature.
I realize that I did not put sufficient documentation for it yet as I wouldn't want to get into it if this addition is unwanted, but the funcitonality is working as intended.
Please check it out, I think its a very simple and at the same time impactful addition to your project.
Best