Open
Conversation
This commit introduces a new 'get' command that simplifies the common workflow of tracking a new series and immediately generating an EPUB for it. The 'get' command is a shortcut for 'track add' followed by 'epub'. The following changes are included: - A new 'get' command is added to the CLI. - The README is updated to document the new command. - The core logic for resolving series from a URL or index is refactored into a new function. - The 'epub' and 'track' commands are updated to use the new refactored function. - A new test is added for the 'get' command.
The 'get' command was passing the namegen_rules string directly to EpubGenerationOptions, which expected a NameGenerator object. This caused a crash when the 'generate' method was called. This commit fixes the issue by instantiating the NameGenerator from the namegen_rules, similar to how it's handled in the 'epub' command.
Owner
|
Thank you for your PR. I will have a look at it to merge this week but it is fine for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since everything I use jncep for is pretty much automated through calling jncep update on a schedule, I wanted to simplify the command line usage.
reliably the only command I have run as of late are jncep track add , followed by jncep epub
This pull request creates a new base command called get that essentially chains the track add and epub functions into one command.
old:
jncep track add https://j-novel.club/series/tearmoon-empire
jncep epub https://j-novel.club/series/tearmoon-empire
new:
jncep get https://j-novel.club/series/tearmoon-empire
I have been using this for a few months now, thought I would offer up the pull request if you were interested.
AnAngryBrit