Open
Conversation
Owner
|
Thank you for your contribution. I will have a look at it soon but it should probably be OK to include the change. Sorry for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since OTP is available through j-novel, I wanted to use it to authenticate instead of passwords, which I'm personally trying to phase out as much as possible. While this might not be useful to those who run jobs, I thought I might share this with others who prefer to avoid passwords, like me.
With this feature, you can use the --otp flag to start the authentication process, add it to your config or as an environment variable. I only implemented it for the main j-novel, since I don't have a Nina account to test with.
This is my first pull request ever, and this is all vibe coding, so no worries if this doesn't work out!
Thanks!