ESIGMA Backward integration #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
esigmapy/generator.py:213
- The error message still references 'orbital_var_names' even though the valid names are now stored in 'all_orbital_var_names'. Please update the error message to reflect the correct variable.
f"{name} is not a valid orbital variable name. Available orbital variable names are: {orbital_var_names}."
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
esigmapy/generator.py:221
- The backward integration branch computes orbital parameters using ls.SimInspiralESIGMADynamicsBackwardInTime and then immediately calls ls.SimInspiralENIGMADynamics with the updated parameters. Please add a clarifying comment to document the rationale behind this two-step integration process.
elif f_ref > f_lower:
| mean_anomaly = l.data.data[-1] | ||
| f_start = f_lower | ||
| elif f_ref < f_lower: | ||
| itime = time.perf_counter() |
There was a problem hiding this comment.
The variable 'itime' is assigned multiple times across different branches. If these timing measurements are important, consider consolidating them or adding comments to clarify their distinct purposes.
Suggested change
| itime = time.perf_counter() | |
| timing_data["f_ref_less_start"] = time.perf_counter() # Start timing when f_ref < f_lower |
prayush
force-pushed
the
backward_integration
branch
from
2af8da9 to
161b008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating ESIGMA waveforms, this PR will enable us to specify the initial conditions at a reference frequency, which can be larger than the starting GW frequency. Currently we only support the cases where the reference frequency is equal to or lower than the starting GW frequency.