Skip to content

Change fancybox gallery name#415

Draft
iaraota wants to merge 1 commit intogwpy:masterfrom
iaraota:move_date_fancybox
Draft

Change fancybox gallery name#415
iaraota wants to merge 1 commit intogwpy:masterfrom
iaraota:move_date_fancybox

Conversation

@iaraota
Copy link
Contributor

@iaraota iaraota commented Aug 8, 2024

This PR updates the Fancybox initialization by changing the data-fancybox attribute from "gallery" to "summary." This modification tailors Fancybox specifically for Summary Pages, introducing new date navigation buttons within the gallery. These buttons allow users to easily switch between different dates. This PR is linked to the associated changes in gwbootstrap PR#63

@iaraota iaraota self-assigned this Aug 8, 2024
@iaraota iaraota marked this pull request as draft August 8, 2024 15:43
@codecov
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.27%. Comparing base (720bd0c) to head (a7326f2).
Report is 13 commits behind head on master.

Files Patch % Lines
gwsumm/tabs/builtin.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   49.64%   49.27%   -0.38%     
==========================================
  Files          60       60              
  Lines        8823     8789      -34     
==========================================
- Hits         4380     4330      -50     
- Misses       4443     4459      +16     
Flag Coverage Δ
Linux 49.27% <0.00%> (-0.38%) ⬇️
macOS 49.27% <0.00%> (?)
python3.10 49.27% <0.00%> (-0.38%) ⬇️
python3.11 49.27% <0.00%> (-0.38%) ⬇️
python3.9 49.27% <0.00%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eagoetz eagoetz self-requested a review December 5, 2024 19:25
@eagoetz eagoetz added this to the 2.3.0 milestone Dec 5, 2024
@eagoetz eagoetz modified the milestones: 2.3.0, 2.3.1 Apr 22, 2025
@eagoetz eagoetz modified the milestones: 2.3.1, 2.4.0 May 7, 2025
@eagoetz eagoetz modified the milestones: 2.4.0, 2.5.0 Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments