added filter and reduce, optimized forEach / map#2
Open
KevinGin wants to merge 2 commits intogyllstromk:masterfrom
Open
added filter and reduce, optimized forEach / map#2KevinGin wants to merge 2 commits intogyllstromk:masterfrom
KevinGin wants to merge 2 commits intogyllstromk:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I added two more iterators -- filter and reduce -- which work as would be expected. I also added tests for each of these new features.
In addition, I optimized the forEach / map methods by specifying the array size up front. (Rather than starting with an empty array and pushing to it, which causes the array to resize under the hood as it grows). I created a Gist to show what I used to compare runtimes. The optimized method seems to be around 4x faster: https://gist.github.com/KevinGin/0bc39e390e2b780122747d1f9a98ed56