Skip to content

Update StubInvocationUtilTest.java#4

Draft
gzhao9 wants to merge 2 commits into3.2from
refactor-StubInvocationUtilTest
Draft

Update StubInvocationUtilTest.java#4
gzhao9 wants to merge 2 commits into3.2from
refactor-StubInvocationUtilTest

Conversation

@gzhao9
Copy link
Copy Markdown
Owner

@gzhao9 gzhao9 commented Oct 8, 2023

Purpose of the Change

This PR is aimed at resolving the issue of duplicated creation of mock. This occurs in five test cases in StubInvocationUtilTest.java, as highlighted in issue # 13153.

Brief changelog

We created 5 reusable methods to create the mock, avoiding duplicate creation of the mock in 5 test cases.
We also set the five mock objects as class attributes and create them in @BeforeEach.
After removing duplicate mocks for 5 test cases, our refactoring reduced the number of lines of code by 76 lines, improving readability and maintainability.

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants