Skip to content

Refactor org.apache.dubbo.reactive.test#5

Draft
gzhao9 wants to merge 5 commits into3.2from
refactor-org.apache.dubbo.reactive.test
Draft

Refactor org.apache.dubbo.reactive.test#5
gzhao9 wants to merge 5 commits into3.2from
refactor-org.apache.dubbo.reactive.test

Conversation

@gzhao9
Copy link
Copy Markdown
Owner

@gzhao9 gzhao9 commented Oct 9, 2023

Purpose of the Change

This PR is aimed at resolving the issue of duplicated creation of mock. This occurs in five test cases in ManyToManyMethodHandlerTest.java, ManyToOneMethodHandlerTest.java and OneToManyMethodHandlerTest.java, as highlighted in issue #13154.

Brief changelog

We created a reusable class creatObserverAdapter to create the mock, avoiding duplicate creation of the mock in 5 test cases.
Since in ManyToOneMethodHandlerTest.java and OneToManyMethodHandlerTest.java, the mock is both created duplicated in two test cases, we set this mock object as a class attribute and create it in @BeforeEach.
After refactoring, we removed duplicate lines of code for the following five test cases and improved readability and maintainability:

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

gzhao9 added 5 commits October 4, 2023 18:39
I observed and found the responseObserver mock. In ManyToManyMethodHandlerTest,

ManyToOneMethodHandlerTest and OneToManyMethodHandlerTest these three have repeatedly creating problems in the test class.

To avoid duplicate creation. I created a class called creatObserverAdapter and set the get method. In the test cases of the three test classes, the get method is used to avoid the repeated creation of mocks and stubs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant