First Iteration of CryptoCurrency Calculator #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified GraphicsCard class(added properties)
Added Uni tests
…onverting currency, added project for ConsoleClient App
added more things to client app
Renamed some classes, Moved some code to new classes and methods
Added generuic Method for displayig and validating Enum, Added More Devices in DeviceProvider, Removed unused code
Change Import() method to use HTTPClient instead of WebClient
so currency can he passed as property name
Modified CryptoCurrency Classes Changed method which calculate roi
another method Changed method which parse enum
with type conversion
Fixed spelling bugs Fixed indentation
… to ETH) Changed hash rate to scientific notation for Bitcoin network difficulty
Added static class for all text
h00jraq
force-pushed
the
feature/CalculateROI
branch
from
9c294a6 to
f625178
Compare
added 3 commits
May 28, 2021 22:22
…type valid currency
index of an device
Moved choosing base type and manufacturer to separate methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works... to some degree :).
Exception handling could be better.
Test are not working, they have to be fixed because methods for both Bitcoin and Ethereum has changed
Need to change some methods so user have to type right values or otherwise he wont be able to continue.
To do:
Better formating
Adding more test and fixing current ones
Making better loops
Adding exception handling
Finishing API for CryptoCurrency data (hash rate, price etc...)