Skip to content

fix: correct is_bitcode_generation_skipped early-return logic#11

Open
duna-feline wants to merge 1 commit intomainfrom
fix/bitcode-skip-logic
Open

fix: correct is_bitcode_generation_skipped early-return logic#11
duna-feline wants to merge 1 commit intomainfrom
fix/bitcode-skip-logic

Conversation

@duna-feline
Copy link
Copy Markdown
Collaborator

Changes

Rewrote is_bitcode_generation_skipped() to use early-return on first matching condition instead of iterating through all conditions.

Before: Loop overwrote message for every match, only logging the last match's reason.
After: Returns immediately on first match with correct reason.

Why

The previous logic was misleading — it appeared to check all conditions but the logged reason could be wrong if multiple conditions matched.

duna-feline added a commit that referenced this pull request Feb 16, 2026
- Add cargo-audit job for dependency security auditing
- Set rust-version = "1.85" in Cargo.toml (minimum for edition 2024)
- Add MSRV check job that builds with Rust 1.85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant