fix: correct is_bitcode_generation_skipped early-return logic#11
Open
duna-feline wants to merge 1 commit intomainfrom
Open
fix: correct is_bitcode_generation_skipped early-return logic#11duna-feline wants to merge 1 commit intomainfrom
duna-feline wants to merge 1 commit intomainfrom
Conversation
duna-feline
added a commit
that referenced
this pull request
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Rewrote
is_bitcode_generation_skipped()to use early-return on first matching condition instead of iterating through all conditions.Before: Loop overwrote
messagefor every match, only logging the last match's reason.After: Returns immediately on first match with correct reason.
Why
The previous logic was misleading — it appeared to check all conditions but the logged reason could be wrong if multiple conditions matched.