Fix uuid generation. uuid is an object, it's uuid.uuid() who's a function#112
Open
sand97 wants to merge 1 commit intoh2non:masterfrom
Open
Fix uuid generation. uuid is an object, it's uuid.uuid() who's a function#112sand97 wants to merge 1 commit intoh2non:masterfrom
sand97 wants to merge 1 commit intoh2non:masterfrom
Conversation
gajanand99
reviewed
Apr 16, 2023
|
|
||
| function randomName() { | ||
| return path.join(os.tmpdir(), 'videoshow-' + uuid()) | ||
| return path.join(os.tmpdir(), 'videoshow-' + uuid.uuid()) |
There was a problem hiding this comment.
Can we use internal Crypto.randomUUID instead of an external library here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you call uuid() it generate and Exception, "...is not a function" in electron production