Skip to content

Milestone 3- Nick Bircher#83

Open
nickbircher wants to merge 6 commits intohack4impact-calpoly:mainfrom
nickbircher:main
Open

Milestone 3- Nick Bircher#83
nickbircher wants to merge 6 commits intohack4impact-calpoly:mainfrom
nickbircher:main

Conversation

@nickbircher
Copy link
Copy Markdown

Milestone: 3

Developer: Nick Bircher

Pull Request Summary

Completed Milestone 3 which transitions Milestone 1 to React. Ready for review.

Pull Request Checklist

  • [ x] Code is neat, readable, and works
  • [ x] Comments are appropriate
  • [ x] The commit message follows our guidelines
  • [ x] The milestone number is specified
  • [ x] The developer name is specified
  • [ x] The summary is completed

Reviewer Checklist - PULL REQUEST REVIEWER ONLY

IMPORTANT: The rest of the sections in this checklist should only be filled out by authorized pull request reviewers. If you are the individual template contributor, do not fill out the rest of the fields or check the boxes.

NOTE: Milestones can only be completed when all boxes are checked.

  • The code is fully reviewed
  • Meaningful feedback is given
  • Comment that you have reviewed the code
  • This box is checked

@nickbircher
Copy link
Copy Markdown
Author

Finished 3.5, 4, 5 as well.

Copy link
Copy Markdown
Collaborator

@vwinstea vwinstea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Nick! Your comment says you completed milestone 5 but you never pushed any of your backend code. Could you push that please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants