feat(sidequest): Add Minequest sidequest#2180
feat(sidequest): Add Minequest sidequest#2180adhyys07 wants to merge 61 commits intohackclub:mainfrom
Conversation
…ncluding image toggle and new UI elements
…d Aiiiiiiiii !!!!!!! hehehehehehehe
…outes and display logic
…d update UI styles for better responsiveness
…ed idea generation logic
…es and clarifications
…nd enhance UI styles for better responsiveness
anirudh12032008
left a comment
There was a problem hiding this comment.
a lot of changes needed
…ion; update Procfile.dev and docker-compose.yml for improved configurations
…improved performance
what i worked oni knocked out a bunch of small but annoying ci issues that were blocking checks. nothing super huge, but all of them were needed to make the pr clean and pass properly. 1. removed trailing spaces in
|
| @sidequest = Sidequest.find_by!(slug: params[:id]) | ||
| requested_slug = params[:id].to_s | ||
| @sidequest = Sidequest.find_by(slug: requested_slug) | ||
| minequest_alias_slugs = [ "minequest", "minequests", "minecraft-art" ] |
There was a problem hiding this comment.
I still don't understand why do we need minequest_alias_slugs?
Delete db/migrate/20260422183848_add_minequest_sidequest.rb
Delete db/migrate/20260415231444_add_minecraft_art_sidequest.rb
anirudh12032008
left a comment
There was a problem hiding this comment.
Everything looks good now
| add_foreign_key "votes", "projects" | ||
| add_foreign_key "votes", "users" | ||
| end | ||
| end No newline at end of file |
There was a problem hiding this comment.
this needs an EOF newline to pass. not sure where it went.
also not sure if this suggestion will work. might be easier to just put the newline in there yourself. (or run bin/rails db:migrate, which will do it for you, despite saying Model files unchanged.)
| end | |
| end |

This pull request introduces several new features and improvements focused on enhancing the "Minequest" sidequest experience, accessibility, and code maintainability. The most significant changes include new Stimulus controllers for Minequest-specific UI behaviors, improvements to the Sidequests controller to better handle Minequest-related logic and idea generation, and some general developer experience tweaks.
Minequest Feature Additions:
Added new Stimulus controllers for Minequest:
minecraft_tabs_controller,sidequests/minequest/accessibility_controller,sidequests/minequest/ideas_controller, andsidequests/minequest/modal_controllerto support custom tab navigation, accessibility toggling for animations, idea generation, and modal interactions on Minequest-related pages. (app/javascript/controllers/minecraft_tabs_controller.js,app/javascript/controllers/sidequests/minequest/accessibility_controller.js, and related imports/registrations) [1] [2] [3]Updated
app/controllers/sidequests_controller.rbto improve handling of the "minequest" slug and related titles, provide custom prize logic, render a dedicated Minequest view, and expose a newgenerate_ideasaction that calls the Gemini API to generate Minecraft sidequest ideas. [1] [2]Accessibility Improvements:
sidequests/minequest/accessibility_controller, allowing users to switch between GIF and PNG representations, with state persisted in local storage.JavaScript Controller Refactoring:
app/javascript/controllers/index.jsto use consistent import and registration style, and registered the new Minequest-related controllers.Developer Experience:
Procfile.devto ensure the JS build process runs persistently by changing the watch command toyarn build --watch=forever.