Skip to content

Conversation

abuna1985
Copy link
Member

Fixes #1703

What changes did you make and why did you make them ?

  • Updated the look and feel of the "Edit Project" page using Material-UI (MUI) components:

    • I replaced some older custom design elements (like basic boxes and buttons) with Material-UI's modern components (like structured pop-up windows, lists, and interactive buttons).
    • I also set up reusable styles for things like list items and text, making them consistent.
    • Why: This makes the page look more consistent with the rest of the application, easier to update in the future, and generally more user-friendly across different devices and for people using assistive technologies.
  • Fixed a visual glitch where buttons and list items sometimes looked "stuck" after closing a pop-up window with the Escape key:

    • After switching to Material-UI, I noticed that when I closed a pop-up (like "Edit Meeting Times" or "Create New Event") by pressing Escape, the button or list item I clicked to open it would sometimes stay highlighted or look "pressed."
    • I fixed this by making sure those elements fully reset their visual state when the pop-up closes this way.
    • Why: This provides a smoother and more reliable user experience, making sure the interface responds correctly to your actions.
  • Removed extra text from the top of the "Edit Meeting Times" and "Create New Event" pop-up windows:

    • Previously, these pop-ups had both a title (like "Edit Meeting Times") and an "X" button to close them. I've removed the title text.
    • Why: This simplifies the design of the pop-up windows, making them cleaner and less cluttered, as their purpose is usually clear from the content inside.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

1-before-full-page-edit-projects


2-before-vrms-edit-project

Visuals after changes are applied

3-after-events-full-page


4-after-edit-project

@abuna1985 abuna1985 changed the title refactor(project-edit): Standardize MUI & Fix Modal Ripples (#1703) refactor(edit-project): Standardize MUI & Fix Modal Ripples (#1703) Jun 18, 2025
@bconti123 bconti123 self-requested a review August 26, 2025 02:45
@bconti123
Copy link
Member

bconti123 commented Sep 8, 2025

Great work! I fixed the merge conflict. I really like the MUI components.

How can I change the "Is this event available for check-in now?" option under Manually Edit Events Checkin from yes to no or no to yes?

@JackHaeg
Copy link
Member

JackHaeg commented Sep 9, 2025

Thanks for fixing the merge conflict @bconti123!

  • As we discussed on tonight's call, the Manually Edit Events Checkin appears to be working as expected.
  • @trillium this PR is ready for a final review / merge when you have a moment. Upcoming changes will likely introduce additional merge conflicts, so we may want to merge this sooner rather than later :)

@JackHaeg
Copy link
Member

JackHaeg commented Sep 9, 2025

@bconti123 Given that we addressed the Manually Edit Events Checkin question last night, can you please approve this PR when you have a moment? We'll still get a 2nd reviewer, but since you did the work of reviewing / approving this PR, I'd like to ensure you get credit for your work of reviewing this.

Copy link
Member

@bconti123 bconti123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved this PR. It is now ready for the 2nd reviewer.

@JackHaeg JackHaeg added the ready for 2nd review When a PR is ready for another reviewer label Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: medium ready for 2nd review When a PR is ready for another reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/components/manageProjects/editProject.jsx
3 participants