[BUIDL Audition Onchain] BE-003: Wallet Signature Verification#68
Open
LaGodxy wants to merge 3 commits intohackinsync:mainfrom
Open
[BUIDL Audition Onchain] BE-003: Wallet Signature Verification#68LaGodxy wants to merge 3 commits intohackinsync:mainfrom
LaGodxy wants to merge 3 commits intohackinsync:mainfrom
Conversation
jedstroke
requested changes
Jul 27, 2025
Member
There was a problem hiding this comment.
@LaGodxy, isn't this test supposed to contain the starknet package, or did you preload it with signatures already?
Member
There was a problem hiding this comment.
'Cause you're supposed to be testing against signed signatures
Member
|
@LaGodxy What's up? |
Contributor
Author
|
@jedstroke |
Contributor
Author
|
@jedstroke |
Member
|
@LaGodxy, what's up? |
Member
|
There's a requested change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Implement Wallet Verification Endpoint using starknet.js
Overview
This PR implements a new
/api/v1/auth/verify-walletendpoint that provides a secure and reusable way to verify wallet ownership through message signatures. The implementation uses starknet.js for signature verification and follows best practices for security, error handling, and performance monitoring.Key Features
Technical Implementation
src/routes/v1/auth.tssrc/types.tsto support the new endpointtests/wallet-verification.test.jsSecurity Considerations
Testing
How to Use
The endpoint accepts POST requests with the following payload:
{ "walletAddress": "0x...", "message": "Sign this message to authenticate", "signature": ["0x...", "0x..."] }Response for successful verification:
{ "error": false, "msg": "Wallet verification successful", "data": { "walletAddress": "0x...", "verified": true, "timestamp": "2025-06-06T19:42:27.000Z", "processingTimeMs": 123 } }Setup Requirements
STARKNET_SEPOLIA_RPC_API_URLandSTARKNET_MAINNET_RPC_API_URLFuture Improvements
Related Issues
Closes #44