Feat/auto emails by janekhuong · Pull Request #949 · hackmcgill/hackerAPI

janekhuong · 2025-10-21T23:53:15Z

Tickets:

HAC-

List of changes:

Added backend functionality for sending batch decision emails

Type of change

New feature (non-breaking change which adds functionality)

How has this been tested?

Create test hackers with valid email addresses. In staff dashboard, change their statuses to accepted/declined. Click "Send Emails" button, choose to send acceptance or declined emails, and then confirm.

Questions for code reviewers?

Middleware.Auth.ensureAuthorized() calls in emails.js is failing; commented out for now but will figure it out

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
Listed change(s) in the Changelog
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
I have made corresponding changes to the documentation
Any dependent changes have been merged and published in downstream modules

joshuazhou744 · 2025-11-07T16:16:18Z

routes/api/emails.js

+         */
+        automatedEmailRouter.route("/automated/status/:status/count").get(
+            Middleware.Auth.ensureAuthenticated(),
+            // Middleware.Auth.ensureAuthorized(),


In the future we can include the handling for the :status parameter for ensureAuthorized in auth.service.js. i'm assuming since it's commented out, currently any hacker can send batch emails using the API bc there's no check to see if api/email/automated/... route is included in the executing user's role.

can we test this? log in as a hacker and try to execute the route in the console. we definitely need to have validation there

we can add permissions for this route to the staff role in the database, and then it should be fine. @janekhuong did you try that? do you need help figuring that out?

joshuazhou744

Looks good, I also tested it once locally. Only thing is there's no user validation for who can use this route (api/email/...)

joshuazhou744

Looks good and works now, I tested on both an authorized and unauthorized account

tektaxi

works great, thanks.

This reverts commit 481d303.

* Update email templates with tentative dates * Create service for sending automated status emails * Created function to find hacker by their status * API routing for automated emails * Cleaner code * API routing for getStatusCount function * Added emails.js logic to middleware and controller files * fixed authorization bug * Added hackboard role support * Revert "Added hackboard role support" This reverts commit 481d303. * update email dates --------- Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Mika Vohl <mikavohl@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com>

#974) * Create checkin form submit endpoint * Finish hacker checkin form submit endpoint * Change checkin form spreadsheet * api route for checking in teams * Add devpost and discord tag field validation * Update db with devpost url * Add url validation: * added team checkin form status to settings * remove workshops * more validation * test * Updated email template dates and header logo * Added hackboard role support * Revert "Added hackboard role support" This reverts commit 481d303. * Feat/auto emails (#949) * Update email templates with tentative dates * Create service for sending automated status emails * Created function to find hacker by their status * API routing for automated emails * Cleaner code * API routing for getStatusCount function * Added emails.js logic to middleware and controller files * fixed authorization bug * Added hackboard role support * Revert "Added hackboard role support" This reverts commit 481d303. * update email dates --------- Co-authored-by: Joshua Zhou <joshuazhou744@gmail.com> Co-authored-by: Mika Vohl <mikavohl@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * Feat/create application review (#944) * not finished create app rev * Reviewer status: 1/2 works (needs to enter twice??) * Hacker Reviewer Feature * Cleaner code * remove uneccessary comments * not finished create app rev * Reviewer status: 1/2 works (needs to enter twice??) * Hacker Reviewer Feature * Cleaner code * remove uneccessary comments * not finished create app rev * Reviewer status: 1/2 works (needs to enter twice??) * Hacker Reviewer Feature * Cleaner code * remove uneccessary comments * not finished create app rev * Reviewer status: 1/2 works (needs to enter twice??) * Hacker Reviewer Feature * Cleaner code * Fixed Application Error: implemented reviewers values from feat/review_filter and fixed the default value errors for reviewer status, name, and comments * Fixed Application Error: implemented reviewers values from feat/review_filter and fixed the default value errors for reviewer status, name, and comments * fixed authorization issues by adding all routes to routes.constant.js with unique IDs * disable emails on status change by admin --------- Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> * fixed merge issue with objectIDs * Added hackboard role support (#955) * Added hackboard role support * minor edits to hackboard permissions --------- Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> * Updated account invitation email content * Feat/assign reviewers (#959) * Assign 2 reviewers per unreviewed Hacker submitted before cutoff time. Will need a cleaning for documentation * removed to requirement that the reviewer name has to be empty (now it's just filtering if hacker was created before cutoff) * clean * Use string[] parameter instead of hardcoded names --------- Co-authored-by: JAMIE XIAO <jamie.xiao.ca@gmail.com> * Added script for sending interest form emails (#954) * Added script for sending interest form emails * Usage comments * quick fixes to assignReviewers (#961) * quick fixes to assignreviewers * fixed non existant fields conditional statements for assignReviewers * need to fix: reviewer1 & 2 have same name * fixed duplicate names * cut off to dec 1 11:59 pm * update cutoff * date fix?? * add hacker id to team api response schema * new acceptance email * updated Marriott booking deadline * round 2 acceptance email template * updated rejection email * updated wording * added volunteer link * added applied status to validateStatus function * overrode email template to send declined emails to hackers with applied status (#972) * Finish hacker checkin form submit endpoint * format sheet name * remove checkin router dup * fix --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca> Co-authored-by: janekhuong <janekhuong05@gmail.com> Co-authored-by: Mika Vohl <mikavohl@gmail.com> Co-authored-by: Tavi Pollard <tavienpollard@gmail.com> Co-authored-by: Jamie Xiao <141690843+JamieXiao@users.noreply.github.com> Co-authored-by: Tavi Pollard <45189395+tektaxi@users.noreply.github.com> Co-authored-by: Mika Vohl <103958325+MikaVohl@users.noreply.github.com> Co-authored-by: JAMIE XIAO <jamie.xiao.ca@gmail.com> Co-authored-by: Mubeen Mohammed <mubeen.mohammed@mail.mcgill.ca>

janekhuong added 6 commits October 21, 2025 18:04

Update email templates with tentative dates

3280a1d

Create service for sending automated status emails

df47e20

Created function to find hacker by their status

7c8752a

API routing for automated emails

22ef0ee

Cleaner code

4bc9f5f

API routing for getStatusCount function

54a66c4

janekhuong had a problem deploying to testing October 21, 2025 23:53 — with GitHub Actions Failure

janekhuong had a problem deploying to testing October 30, 2025 00:19 — with GitHub Actions Failure

janekhuong force-pushed the feat/auto-emails branch from d84cee2 to 54a66c4 Compare October 30, 2025 00:23

Added emails.js logic to middleware and controller files

050f443

joshuazhou744 reviewed Nov 7, 2025

View reviewed changes

joshuazhou744 approved these changes Nov 7, 2025

View reviewed changes

fixed authorization bug

67fcb7e

joshuazhou744 approved these changes Nov 8, 2025

View reviewed changes

Merge branch 'dev' into feat/auto-emails

7508575

joshuazhou744 had a problem deploying to testing November 8, 2025 19:18 — with GitHub Actions Failure

tektaxi mentioned this pull request Nov 17, 2025

Added hackboard role support #955

Merged

tektaxi approved these changes Nov 17, 2025

View reviewed changes

MikaVohl added 2 commits November 17, 2025 14:08

Added hackboard role support

e3146f0

Revert "Added hackboard role support"

3258fc8

This reverts commit 481d303.

tektaxi had a problem deploying to testing November 17, 2025 19:08 — with GitHub Actions Failure

update email dates

635a7d5

tektaxi had a problem deploying to testing November 17, 2025 19:12 — with GitHub Actions Failure

tektaxi merged commit fbcdfc7 into dev Nov 17, 2025
1 check failed

tektaxi deleted the feat/auto-emails branch November 17, 2025 19:14

tektaxi mentioned this pull request Jan 17, 2026

Feat/Team Checkin Form routes, validators, controllers, and middlewar… #975

Merged

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/auto emails#949

Feat/auto emails#949
tektaxi merged 12 commits intodevfrom
feat/auto-emails

janekhuong commented Oct 21, 2025 •

edited

Loading

Uh oh!

joshuazhou744 Nov 7, 2025

Uh oh!

tektaxi Nov 7, 2025

Uh oh!

tektaxi Nov 7, 2025

Uh oh!

joshuazhou744 left a comment

Uh oh!

joshuazhou744 left a comment

Uh oh!

tektaxi left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

janekhuong commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tickets:

List of changes:

Type of change

How has this been tested?

Questions for code reviewers?

Checklist:

Uh oh!

joshuazhou744 Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

tektaxi Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

tektaxi Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

joshuazhou744 left a comment

Choose a reason for hiding this comment

Uh oh!

joshuazhou744 left a comment

Choose a reason for hiding this comment

Uh oh!

tektaxi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

janekhuong commented Oct 21, 2025 •

edited

Loading