This repository was archived by the owner on Sep 5, 2024. It is now read-only.
Fix regression of #267 (Error: col val outside range) #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- opts.col passed to nvim_buf_set_extmark() expects it to be 0-indexed. pull#315 causes an empty line to retun 1 for cursor's column. This PR checks if the current line is empty and sets the correct column in 'contexts' that'll be used later in nvim_buf_set_extmark() in set_unmatched_lines()
|
Is something preventing this PR from being merged? |
|
Been waiting for this for a while. I'm pinned to a previous (and pretty old) commit so that I can continue to use this plugin. I'm excited for this issue to be resolved so I can update. |
|
Until the maintainer finds time to maintain the PRs in this repo again, I'll try to get maintenance / somehow critical stuff into this fork: https://github.com/mistweaverco/hop.nvim I cherry picked your commit into the master branch of the fork already :) Thanks for your effort! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression of #267 caused by pull#315