Open
Conversation
Currently the async client is broken by commit 55001da Every line of that commit is wrong: it frees the async data that is saved by async_send() callback for later use in async recv. Also it frees `fstr` which is also freed in transport_send() of demo-async-client.c. This patch undoes most of commit 55001da It is also an option to do the plain revert, but, considering that it is already 10 years old, I decided that freeing of `fstr` in searpc_client_async_call_v() can be left as is now, and instead, this patch removes it from transport_send() of demo-async-client.c. With this patch, the async APIs can be used again.
stsp
added a commit
to dosemu2/dosemu2
that referenced
this pull request
Apr 4, 2026
Unfortunately this doesn't work currently due to: haiwen/libsearpc#79 Also the speed-up heavily depends on the overall system load, and decreases only on a "quiet" system. Perhaps an RPC server needs a realtime prio to avoid hickups...
stsp
added a commit
to dosemu2/dosemu2
that referenced
this pull request
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the async client is broken by commit 55001da
Every line of that commit is wrong: it frees the async data that
is saved by async_send() callback for later use in async recv. Also it frees
fstrwhich is also freed in transport_send() of demo-async-client.c.
This patch undoes most of commit 55001da
It is also an option to do the plain revert, but, considering that it is already 10 years old,
I decided that freeing of
fstrin searpc_client_async_call_v() can be left as is now, and instead,this patch removes it from transport_send() of demo-async-client.c.
With this patch, the async APIs can be used again.