HAL-1990: remove unnecessary copying of complex attributes #1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One usage of the
copyComplexAttributeAttributesremains for a list type attribute but I think it might be removed if we made the form use request properties, I haven't tried changing it so I don't break something else.I will try to improve the credential reference handling, e.g. the validator used in the Elytron presenters doesn't look like it works the same way as the
CredentialReference.CrFormValuesValidationand requires/alternatives validation doesn't work out of the box on the flattened attributes either, but that's out of the scope for this issue.