feat: Support CSRF token retrieval from header "X-CSRF-Token" #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterT
commented
Apr 1, 2023
| # | ||
| # Override this method, for custom handling of the request token retrieval. | ||
| # | ||
| # @since 2.X.X |
Contributor
Author
There was a problem hiding this comment.
What should the version be?
Member
|
Thanks for putting this together, @masterT! However, rather than leave this as a hook inside actions for users to override, I'd prefer we just fully build in support for checking the header for the CSRF token in addition to the request's params. Would you like to have a go at doing that? |
Contributor
Author
|
Sure, I will craft something. |
masterT
changed the title
Contributor
Author
|
I did implement your suggestion, this is ready for review. 🙂 @timriley |
timriley
force-pushed
the
feature-custom-csrf-token-retrieval
branch
from
184fa47 to
32f467d
Compare
Member
|
Thanks again for this feature, @masterT! Your second round of changes looks perfect, and I'll be very happy for us to release this with Hanami 2.3 next week :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieve the request CSRF token from the HTTP header
X-CSRF-Tokenin the case the params_csrf_tokenis not provided.Reference: