Skip to content

Export HTTP.TransactionOptions#670

Merged
nodech merged 1 commit intohandshake-org:masterfrom
nodech:export-transactionoptions-fix
Dec 9, 2021
Merged

Export HTTP.TransactionOptions#670
nodech merged 1 commit intohandshake-org:masterfrom
nodech:export-transactionoptions-fix

Conversation

@nodech
Copy link
Contributor

@nodech nodech commented Dec 9, 2021

Fixes the style issues in that PR.

Closes #392

@nodech nodech self-assigned this Dec 9, 2021
@nodech nodech added wallet part of the codebase wallet-api part of the codebase wallet-http part of the codebase quick review difficulty - easy labels Dec 9, 2021
@coveralls
Copy link

coveralls commented Dec 9, 2021

Pull Request Test Coverage Report for Build 1558282263

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 8 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.02%) to 62.488%

Files with Coverage Reduction New Missed Lines %
lib/covenants/rules.js 1 69.11%
lib/protocol/consensus.js 1 82.79%
lib/script/script.js 1 63.25%
lib/net/pool.js 2 30.34%
lib/wallet/http.js 3 63.53%
Totals Coverage Status
Change from base Build 1521306511: -0.02%
Covered Lines: 21236
Relevant Lines: 31792

💛 - Coveralls

@nodech nodech force-pushed the export-transactionoptions-fix branch from 338341a to 68e6610 Compare December 9, 2021 10:31
@nodech nodech merged commit e1d3969 into handshake-org:master Dec 9, 2021
@nodech nodech added the patch Release version label Dec 9, 2021
@nodech nodech deleted the export-transactionoptions-fix branch January 6, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Release version quick review difficulty - easy wallet part of the codebase wallet-api part of the codebase wallet-http part of the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants