Skip to content

wallet: makeOpen will remove added output if output is doubleOpen.#944

Merged
nodech merged 1 commit intohandshake-org:masterfrom
nodech:fix-partial-open
Aug 22, 2025
Merged

wallet: makeOpen will remove added output if output is doubleOpen.#944
nodech merged 1 commit intohandshake-org:masterfrom
nodech:fix-partial-open

Conversation

@nodech
Copy link
Contributor

@nodech nodech commented Aug 20, 2025

If partial batching is used double open errors would still leave the outputs in mtx making OPEN txs invalid.

This ensures it is removed if check fails.

@nodech nodech added bug general - Something isn't working quick review difficulty - easy wallet part of the codebase patch Release version labels Aug 20, 2025
@coveralls
Copy link

Coverage Status

coverage: 71.653% (+0.02%) from 71.638%
when pulling 2ae6584 on nodech:fix-partial-open
into 8f42b5d on handshake-org:master.

@nodech nodech merged commit 698e252 into handshake-org:master Aug 22, 2025
15 of 16 checks passed
@nodech nodech deleted the fix-partial-open branch August 22, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug general - Something isn't working patch Release version quick review difficulty - easy wallet part of the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants