Use dataset defined labels instead of hard-coded “cells” and “genes”#239
Open
davehorsfall wants to merge 1 commit intodevfrom
Open
Use dataset defined labels instead of hard-coded “cells” and “genes”#239davehorsfall wants to merge 1 commit intodevfrom
davehorsfall wants to merge 1 commit intodevfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
- Coverage 13.96% 13.85% -0.11%
==========================================
Files 73 73
Lines 2385 2403 +18
Branches 576 577 +1
==========================================
Hits 333 333
- Misses 1991 2009 +18
Partials 61 61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
davehorsfall
changed the title
dannda
reviewed
Feb 25, 2026
Comment on lines
+77
to
+80
| valueLabel: { | ||
| singular: 'expression', | ||
| plural: 'expression', | ||
| }, |
Contributor
There was a problem hiding this comment.
just to check, does valueLabel need a singular and plural? or does it only need to be a string value
dannda
reviewed
Feb 25, 2026
| {!varList.length ? ( | ||
| <Alert variant="light">Search for a feature.</Alert> | ||
| <Alert variant="light"> | ||
| Search for a {dataset.varLabel.singular} |
Contributor
There was a problem hiding this comment.
just flagging if we want to avoid using "a {something}" to avoid needing to check if it is "a" or "an"
dannda
reviewed
Feb 25, 2026
| 'features' | ||
| dataset.varLabel.plural | ||
| )}{' '} | ||
| to display their expression distributions across all observations. |
Contributor
There was a problem hiding this comment.
Suggested change
| to display their expression distributions across all observations. | |
| to display their {dataset.valueLabel.singular} distributions across all observations. |
dannda
reviewed
Feb 25, 2026
| 'features' | ||
| dataset.varLabel.plural | ||
| )}{' '} | ||
| to display their expression across groups, then choose a{' '} |
Contributor
There was a problem hiding this comment.
Suggested change
| to display their expression across groups, then choose a{' '} | |
| to display their {dataset.valueLabel.singular} across groups, then choose a{' '} |
dannda
reviewed
Feb 25, 2026
| 'features' | ||
| dataset.varLabel.plural | ||
| )}{' '} | ||
| to display their expression, then choose a{' '} |
Contributor
There was a problem hiding this comment.
Suggested change
| to display their expression, then choose a{' '} | |
| to display their {dataset.valueLabel.singular}, then choose a{' '} |
dannda
requested changes
Feb 25, 2026
Contributor
dannda
left a comment
dannda
left a comment
There was a problem hiding this comment.
can this be added to the docs please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the UI to use dataset-driven labels instead of hard-coded terminology like “cells” and “genes”. This makes text flexible to different data modalities by using values from the dataset configuration (DatasetContext), including:
Changes include:
dataset.varLabel,dataset.obsLabel, anddataset.valueLabelobsSearchColdisplayNameFixes #238
Related to # (if applicable)
Type of change
Checklist
npm test)pre-commit run --all-files)