Open
Conversation
…e media caption fixes #93
There was a problem hiding this comment.
Pull request overview
Adds a new long-form text field to the data.media Strapi component so media entries can store additional text beyond the underlying uploaded asset’s caption limit (per #93).
Changes:
- Add
descriptionattribute (typetext) tosrc/components/data/media.json.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "title": { | ||
| "type": "string" | ||
| }, | ||
| "description": { |
There was a problem hiding this comment.
Issue #93 and the component’s semantics describe this as a (long) "caption" for the media, but the new attribute is named "description". Since this becomes part of the public API, consider renaming the field to "caption" (or another clearly caption-specific name), or update the issue/consumer expectations to avoid ambiguity with other "description" fields in the schema.
Suggested change
| "description": { | |
| "caption": { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add description field to data.media to hold text longer that the media caption
fixes #93
Type of change
Checklist
npm test)pre-commit run --all-files)