Skip to content

Issue #8: Fixes more than 1 result in Active Directory #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Issue #8: Fixes more than 1 result in Active Directory #20

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87ea8f8
Fixes more than 1 result in Active Directory
defrox Feb 17, 2021
18a9733
Update ldapauthenticator.py
defrox Feb 17, 2021
648918d
Update ldapauthenticator.py
defrox Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ldapauthenticator/ldapauthenticator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,9 @@ def authenticate(self, handler: web.RequestHandler, data: dict) -> typing.Option
search_scope=ldap3.SUBTREE,
attributes=self.user_membership_attribute if self.allowed_groups else list(),
paged_size=2)

# remove all searchResRef from response
conn.response = [search_ref for search_ref in conn.response if 'type' in search_ref and search_ref['type'] != 'searchResRef']

# handle abnormal search results
if not conn.response or len(conn.response) > 1:
Expand Down