feat: load token from url query parameter #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have also updated the validator and some old tests in consideration of the new parameter |
Contributor
Author
|
@Marsup Could you review this ? |
|
I'm not a fan of adding support for a use case that is likely to inadvertently expose the tokens to standard logging tools. The url including the query part is included in most HTTP server logs, and can also easily be exposed by clients through system logs. Probably better explained in this SO answer. |
Contributor
Author
|
@kanongil But what about use cases like signed urls from signup links and stuff ? Isn't these best left to the user of the library ? |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49