Feature: Added ejection popup UI displaying player ejected/voted off#12
Open
ellapitts wants to merge 2 commits intohaplesshero13:mainfrom
Open
Feature: Added ejection popup UI displaying player ejected/voted off#12ellapitts wants to merge 2 commits intohaplesshero13:mainfrom
ellapitts wants to merge 2 commits intohaplesshero13:mainfrom
Conversation
| ejection_text = f"{eliminated_player.name} ({eliminated_player.color}) was ejected!" | ||
| system_announcement += f"{ejection_text}\n" | ||
|
|
||
| if self.UI and hasattr(self.UI, "show_ejected_player"): |
Owner
There was a problem hiding this comment.
Actually, can you move this BELOW the "no one was ejected" so you can show both cases?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a simple popup to display the voting results/ejections in the center of the screen.
voteoutmethod to include a player's color in the string so the popup is informative (game.py in amongagents/...)