Open
Conversation
PathogenDavid
approved these changes
Jul 19, 2025
Collaborator
PathogenDavid
left a comment
PathogenDavid
left a comment
There was a problem hiding this comment.
Looks good at a glance! It'd probably be a good idea to figure out why pico_get_unique_board_id is broken in the Pico core at some point though since it might be indicative of a deeper issue.
As an aside, the register got renamed to R_UID when it was ratified in harp-tech/protocol#39. Would be good to update the Pico core to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the RP2040, pull the ID from the flash chip. (The current API sometimes reads all-zeros when calling
get_unique_board_id.) Also fix an endianness issue where the wrong byte range was being populated.Partially addresses #62 for the rp2040.